Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade axios to ^1.5.0 #1035

Closed
Thinkscape opened this issue Sep 18, 2023 · 5 comments · May be fixed by abdu11aev-samandar/metrics#53, abdu11aev-samandar/metrics#54, abdu11aev-samandar/metrics#55, abdu11aev-samandar/metrics#56 or abdu11aev-samandar/metrics#57
Closed

Upgrade axios to ^1.5.0 #1035

Thinkscape opened this issue Sep 18, 2023 · 5 comments · May be fixed by abdu11aev-samandar/metrics#53, abdu11aev-samandar/metrics#54, abdu11aev-samandar/metrics#55, abdu11aev-samandar/metrics#56 or abdu11aev-samandar/metrics#57
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. released type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@Thinkscape
Copy link

It seems that the library is using an ancient version of Axios.

Could we upgrade to stable ^1.5.0?
@Thinkscape Thinkscape added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 18, 2023
@wangela
Copy link
Member

wangela commented Sep 18, 2023

If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.

@Thinkscape Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@damir-minkashev
Copy link

damir-minkashev commented Sep 29, 2023 •
edited
Loading

Upgrading axios would be great. I have an issue and upgrading could solve it, i guess

@adamghowiba
Copy link

This would be a huge help. I'm unable to check if an error is an instance of AxiosError because of my version mismatch. I have to manually rethrow an AxiosError.

@usefulthink
Copy link
Contributor

Unfortunately, there isn't really a guide on how to do that migration. It looks like axios 1.x has a completely different API surface than the 0.x versions. Any hints here?

@usefulthink usefulthink added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Oct 6, 2023
googlemaps-bot added a commit that referenced this issue Oct 9, 2023
@googlemaps-bot
chore(release): 3.3.40 [skip ci]
92a5b5a 
### [3.3.40](v3.3.39...v3.3.40) (2023-10-09)

### Bug Fixes

* only use pre-ESM dependencies ([#1047](#1047)) ([a0d416b](a0d416b))

### Miscellaneous Chores

* update all dependencies ([#1044](#1044)) ([c5c0990](c5c0990)), closes [#1035](#1035)

### Build System

* **deps:** bump retry-axios from 2.6.0 to 3.1.0 ([#1027](#1027)) ([dacfff6](dacfff6))
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.3.40 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Sep 10, 2024
Open
Open
Open
This was referenced Sep 20, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. released type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade: vue, , , , , , , axios, d3, ejs, express, express-rate-limit, file-type, jsdom, libxmljs2, linguist-js, marked, minimatch, node-fetch, open-graph-scraper, puppeteer, rss-parser, sanitize-html, sharp, simple-git, svgo, xml-formatter abdu11aev-samandar/metrics
[Snyk] Upgrade: vue, , , , , , , axios, d3, ejs, express, express-rate-limit, file-type, jsdom, libxmljs2, linguist-js, marked, minimatch, node-fetch, open-graph-scraper, puppeteer, rss-parser, sanitize-html, sharp, simple-git, svgo, xml-formatter abdu11aev-samandar/metrics
[Snyk] Upgrade: vue, , , , , , , axios, d3, ejs, express, express-rate-limit, file-type, jsdom, libxmljs2, linguist-js, marked, minimatch, node-fetch, open-graph-scraper, puppeteer, rss-parser, sanitize-html, sharp, simple-git, svgo, xml-formatter abdu11aev-samandar/metrics
[Snyk] Upgrade: vue, , , , , , , axios, d3, ejs, express, express-rate-limit, file-type, jsdom, libxmljs2, linguist-js, marked, minimatch, node-fetch, open-graph-scraper, puppeteer, rss-parser, sanitize-html, sharp, simple-git, svgo, xml-formatter abdu11aev-samandar/metrics
[Snyk] Upgrade: vue, , , , , , , axios, d3, ejs, express, express-rate-limit, file-type, jsdom, libxmljs2, linguist-js, marked, minimatch, node-fetch, open-graph-scraper, puppeteer, rss-parser, sanitize-html, sharp, simple-git, svgo, xml-formatter abdu11aev-samandar/metrics
6 participants
@usefulthink @Thinkscape @wangela @adamghowiba @damir-minkashev @googlemaps-bot