Move xDS and protobuf definitions into separate crates. #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
markmandel,
koslib and
Jake-Shadle
as code owners
XAMPPRocky
force-pushed
the
ep/xds-lib
branch
3 times, most recently
from
5e2f0f7 to
84d2d33
Compare
Jake-Shadle
approved these changes
May 22, 2024
This commit moves the xDS functionality in its own library, with the eventual goal of making the xDS component its own library that can be used by other services, currently this just extracts the functionality as-is, with the only change being the addition of the `xds::config::Configuration` trait which abstracts over the usage of `config::Config` in xDS as I wanted to keep that in the Quilkin library. The `quilkin-proto` library was also added to allow for the protobuf definitions to be shared between the xDS library and the quilkin application.
|
Build Succeeded 🥳 Build Id: 01cb84ce-cc6c-4bab-9f87-df88698ab7fb The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the xDS functionality in its own library, with the eventual goal of making the xDS component its own library that can be used by other services, currently this just extracts the functionality as-is, with the only change being the addition of the
xds::config::Configurationtrait which abstracts over the usage ofconfig::Configin xDS as I wanted to keep that in the Quilkin library.The
quilkin-protolibrary was also added to allow for the protobuf definitions to be shared between the xDS library and the quilkin application.