Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore config maps for agents #957

Merged
merged 1 commit into from
May 16, 2024
Merged

Ignore config maps for agents #957

merged 1 commit into from
May 16, 2024

Conversation

Jake-Shadle
Copy link
Collaborator

Resolves: #955

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: f3c9e64f-ba9f-466f-8d91-0dcb1d8f1787

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/957/head:pr_957 && git checkout pr_957
cargo build

Copy link
Collaborator

@XAMPPRocky XAMPPRocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think in the future we should consider splitting providers by config data, and have components expose which config data they support. I think that would be both simpler from a user perspective, removes edge cases like this, and enables people to mix and match their desired configuration sources E.g.

--gameservers.k8s=gameservers
--filters.k8s=quilkin
// OR
--gameservers.file=gameservers.yaml
--filters.file=filters.yaml

@XAMPPRocky XAMPPRocky merged commit 69fb369 into main May 16, 2024
11 checks passed
@Jake-Shadle Jake-Shadle deleted the ignore-config-map branch May 16, 2024 09:50
@markmandel markmandel added the kind/bug Something isn't working label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent's Kubernetes provider should not depend on ConfigMap
4 participants