Allow null ports and address fields in GameServer CRD

[XAMPPRocky]

No description provided.

[quilkin-bot]

Build Failed 😭

Build Id: 44259278-4a67-40c7-a6fd-58c56f191957

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

Filter with the Git Commit 795662a within us-docker.pkg.dev/quilkin/ci//quilkin to see if a development image is available from this build, and can be used for debugging purposes.

Development images are retained for at least 30 days.

[markmandel]

Thank you! I was in the process of upgrading the Agones test infra, and ran into the same thing 👍🏻

[XAMPPRocky]

It seems like the test infra is failing though 🧐 does it need to be upgraded at the same time?

[markmandel]

It seems like the test infra is failing though 🧐 does it need to be upgraded at the same time?

Oh! Maybe!

I wonder if that older version of Agones even had the "addresses" field. It's quite possible it didn't - it's quite old.

So two options:

1. We make deserialize_null_default code handle fields it can't find any data for.
2. I can pull this code into the Agones upgrade I'm working on right now.

No. 1 wouldn't be bad to have, but also happy to do No 2., since the test infra is running Agones 1.33, which is almost a year old.

[XAMPPRocky]

I'd prefer No. 2, I can use the image in the mean time.

[markmandel]

I'd prefer No. 2, I can use the image in the mean time.

I also can't find a good way to even check that the field data is missing 🤔 I'm not sure how #[serde(default)] does this.

The error that comes back from let opt = Option::deserialize(deserializer)?; is from https://docs.rs/serde/1.0.200/serde/de/trait.Error.html#method.missing_field and all errors are Trait serde::de::Error 🤔 so you can't differentiate without looking at the text of the error string.

[markmandel]

Confirmed - combining your change with the Agones update passes locally! Will submit a combined PR, and update the cluster.