Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Agones CRD #937

Merged
merged 1 commit into from
May 2, 2024
Merged

Upgrade Agones CRD #937

merged 1 commit into from
May 2, 2024

Conversation

XAMPPRocky
Copy link
Collaborator

@XAMPPRocky XAMPPRocky commented Apr 30, 2024 •
edited
Loading

Upgrading the latest agones, the CRD is out of sync with our version in the Quilkin repo, this PR will solve it.

  • First we're just using a version of kube that exposes more information about what is breaking so we can fix it.

Resolves #938

@XAMPPRocky XAMPPRocky marked this pull request as draft April 30, 2024 08:32
@XAMPPRocky XAMPPRocky force-pushed the ep/upgrade-agones-schema branch from 94224c3 to 8eedc44 Compare April 30, 2024 09:50
@github-actions github-actions bot added size/xs and removed size/l labels Apr 30, 2024
@XAMPPRocky XAMPPRocky marked this pull request as ready for review April 30, 2024 09:50
@XAMPPRocky XAMPPRocky force-pushed the ep/upgrade-agones-schema branch from 8eedc44 to 6307117 Compare April 30, 2024 12:19
@XAMPPRocky XAMPPRocky force-pushed the ep/upgrade-agones-schema branch from 6307117 to f2889af Compare April 30, 2024 12:35
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: e24d0c69-a56e-4a7f-9d55-814bbee7f550

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/937/head:pr_937 && git checkout pr_937
cargo build

@markmandel markmandel merged commit ca1d668 into main May 2, 2024
11 checks passed
@markmandel markmandel deleted the ep/upgrade-agones-schema branch May 2, 2024 18:52
@markmandel markmandel added area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@koslib koslib Awaiting requested review from koslib koslib is a code owner

@Jake-Shadle Jake-Shadle Awaiting requested review from Jake-Shadle Jake-Shadle is a code owner

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc kind/cleanup Refactoring code, fixing up documentation, etc size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gameserver events are failing due parsing errors
3 participants
@XAMPPRocky @quilkin-bot @markmandel