-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node address selection via type and ip kind #934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Shadle
requested review from
markmandel,
XAMPPRocky and
koslib
as code owners
April 25, 2024 09:47
XAMPPRocky
approved these changes
Apr 25, 2024
markmandel
reviewed
Apr 25, 2024
Jake-Shadle
changed the title
Add node address selection via type
Add node address selection via type and ip kind
Apr 26, 2024
XAMPPRocky
reviewed
Apr 26, 2024
XAMPPRocky
approved these changes
Apr 26, 2024
Retrying to see if a flake:
|
Looks like same error. |
Build Succeeded 🥳 Build Id: c946a765-b778-4ce2-934b-6579a3c3d309 The following development images have been built, and will exist for the next 30 days: To build this version:
|
XAMPPRocky
added a commit
that referenced
this pull request
May 15, 2024
This reverts commit df7b5f2.
markmandel
added
kind/feature
New feature or request
area/operations
Installation, updating, metrics etc
labels
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #933