Make idle request logs debug #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
markmandel,
koslib and
Jake-Shadle
as code owners
markmandel
reviewed
Mar 22, 2024
src/net/xds/client.rs
Outdated
| @@ -682,7 +682,7 @@ impl AdsStream { | |||
| break; | |||
| } | |||
| Err(_) => { | |||
| tracing::info!( | |||
| tracing::warn!( | |||
There was a problem hiding this comment.
Triple checking - is it a bad thing if this log shows up?
Moving to warn will this will still show up in info level logging, and look to end users like it's a bigger deal than before -- should this also be debug, or is it actually something they should be aware of?
Jake-Shadle
approved these changes
Mar 22, 2024
XAMPPRocky
commented
Mar 22, 2024
|
Build Succeeded 🥳 Build Id: b631869f-5d08-4c52-8f41-690207f3fc6a The following development images have been built, and will exist for the next 30 days: To build this version: |
markmandel
added
area/operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.