Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send back an empty delta response for initial ignore-me #892

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Jake-Shadle
Copy link
Collaborator

The initial request, which should be the only ignore-me request was being treated as a regular request. Note there is apparently no test that covers this case otherwise the bug wouldn't have been merged

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 2ad0aeb2-e68e-4af9-9f29-856000276292

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/892/head:pr_892 && git checkout pr_892
cargo build

@XAMPPRocky XAMPPRocky enabled auto-merge (squash) February 6, 2024 08:27
@XAMPPRocky XAMPPRocky merged commit 7bc119a into main Feb 6, 2024
5 checks passed
@Jake-Shadle Jake-Shadle deleted the ignore-harder branch February 6, 2024 08:29
@markmandel markmandel added kind/bug Something isn't working area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc kind/bug Something isn't working size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants