Rollup of various changes #749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
markmandel,
No-ops,
rezvaneh and
vallfors
as code owners
XAMPPRocky
force-pushed
the
ep/rollup-05-29
branch
from
64a79fc to
0281e43
Compare
|
Build Succeeded 🥳 Build Id: c1eac303-022b-426c-bba4-85c8c83a7452 The following development images have been built, and will exist for the next 30 days: To build this version: |
markmandel
reviewed
May 30, 2023
| } | ||
|
|
||
| pub(crate) fn packets_total(direction: Direction) -> IntCounter { | ||
| pub(crate) fn packets_total(direction: Direction, asn: Option<&IpNetEntry>) -> IntCounter { |
There was a problem hiding this comment.
(adding review here ,since this is the one that will get merged)
Looks good - only thing to add would be some docs to metrics.md to document the new metrics, otherwise, good to merge 👍🏻
|
Closing this as half the pull requests are now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup of the following PRs.