Move QCMP to a seperate port #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
markmandel,
No-ops,
rezvaneh and
vallfors
as code owners
XAMPPRocky
force-pushed
the
ep/new-qcmp-port
branch
from
2f45769 to
d87cfc9
Compare
XAMPPRocky
force-pushed
the
ep/new-qcmp-port
branch
from
d87cfc9 to
8a99b58
Compare
|
@markmandel 503 on the lib.rs again, should we just change it to |
We ignore crates.io links as well, since they also don't like to be crawled. I'll mark this link as ignored as well in my prep for 0.7.0 PR, and update the User Agent we use as well. |
|
Build Succeeded 🥳 Build Id: beace98f-0d6e-4249-a4f6-d32ac8262aa8 The following development images have been built, and will exist for the next 30 days: To build this version: |
markmandel
added
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves QCMP onto its own port and worker in the proxy, I initially I thought I needed this, but after I wrote I found a better solution in the client, but I decided to open the PR anyway as makes the implementation cleaner and in theory faster as it avoids allocating on the heap (though I haven't actually measured if this is noticeable). This has the added benefit of allowing operators to choose to disable the protocol by not exposing the port, or allowing operators to have QCMP only instances.
Also I removed the
shutdown_rxin the downstream workers as that would cause the process to stop accepting packets after it shut down.