Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded pin requirement #692

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Remove unneeded pin requirement #692

merged 2 commits into from
Jan 26, 2023

Conversation

XAMPPRocky
Copy link
Collaborator

This pin wasn't needed, this removes an extra heap allocation and needing virtual dispatch.

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 74505a4b-9a89-42c0-b1e5-ab50ccbafb01

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/692/head:pr_692 && git checkout pr_692
cargo build

@markmandel markmandel merged commit bf3b43a into main Jan 26, 2023
@markmandel markmandel deleted the ep/remove-pin branch January 26, 2023 20:54
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@No-ops No-ops Awaiting requested review from No-ops

@rezvaneh rezvaneh Awaiting requested review from rezvaneh

@vallfors vallfors Awaiting requested review from vallfors

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XAMPPRocky @quilkin-bot @markmandel