Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotfix around xDS stream sometimes not responding with changes #683

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

XAMPPRocky
Copy link
Collaborator

This is a hot fix for #682, as mentioned, this isn't a complete fix for the issue, but it should be good enough for now to ensure that any updates don't get forgotten, and I think we'll want to keep this implementation of the hotfix in even after we properly fix the issue, as there could be other network issues which this would hopefully solve.

This hot fix is similar to before we're we set the client to repeatedly request new information. The difference between this and the old version, is that this will now only set updates after a set timeout where the proxy hasn't received any new updates, rather than a fixed polling rate, this ensures that there can only be so much drift between a proxy and management server before the proxy starts asking the management server for new information.

@markmandel markmandel enabled auto-merge (squash) January 17, 2023 20:01
@markmandel markmandel added the kind/bug Something isn't working label Jan 17, 2023
@markmandel markmandel merged commit 440f514 into main Jan 17, 2023
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 20ac940a-022a-4ea8-8da0-c9e3977a4d52

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/683/head:pr_683 && git checkout pr_683
cargo build

@markmandel markmandel deleted the ep/hotfix-xds branch January 17, 2023 20:53
@luckyswede luckyswede mentioned this pull request Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants