Add Validation to Config #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed validation that endpoint names are unique, so implemented a validation function for config. This had a few ripple on effects: - impl block for Config, so made sense to pull `from_reader` into that as a static method. - Needed concrete Error types (impacts #67) for validation and other potential error conditions. `from_reader` will now call validate() to ensure that the struct is valid before completing. `validate` was also left as public, since Config's can be manually created before passing them into `Server.run()`
markmandel
commented
Jul 8, 2020
markmandel
commented
Jul 8, 2020
iffyio
reviewed
Jul 8, 2020
|
Updated! |
iffyio
approved these changes
Jul 10, 2020
src/config.rs
Outdated
| impl Config { | ||
| /// from_reader returns a config from a given Reader | ||
| pub fn from_reader<R: io::Read>(input: R) -> Result<Config, serde_yaml::Error> { | ||
| let config: Config = serde_yaml::from_reader(input)?; |
There was a problem hiding this comment.
rust lets us do
pub fn from_reader<R: io::Read>(input: R) -> Result<Config, serde_yaml::Error> {
serde_yaml::from_reader(input)
}if we wanted to avoid specify the type or rewrapping the value
There was a problem hiding this comment.
Oh yeah, why isn't this just one line. I'll clean this up before merging.
markmandel
force-pushed
the
config/validation
branch
from
683093c to
9b579f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed validation that endpoint names are unique, so implemented a validation function for config. This had a few ripple on effects:
from_readerinto that as a static method.from_readerwill now call validate() to ensure that the struct is valid before completing.validatewas also left as public, since Config's can be manually created before passing them intoServer.run()