Replace SessionManager with TtlMap, refactor downstream packet processing to track more errors in metrics #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing to track more errors in metrics
XAMPPRocky
requested review from
markmandel,
No-ops,
rezvaneh and
vallfors
as code owners
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Succeeded 🥳 Build Id: dcab35c5-93a5-4047-82c4-93f6eac313cd The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that we essentially implemented the same thing with
SessionManagerandTtlMap, so I removed session manager and replaced it withTtlMap, while also changing this code, I updated the downstream processing code, because there were cases were errors can happen but wouldn't be tracked in metrics, so now the code is written to ensure that all paths lead to the metrics being counted.