Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #651

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Update dependencies #651

merged 3 commits into from
Nov 30, 2022

Conversation

XAMPPRocky
Copy link
Collaborator

No description provided.

@XAMPPRocky
Copy link
Collaborator Author

@markmandel Would you be able to help me out with this? No matter what I try, I can't get a protobuf compiler visible for both the main build and example project, and there seem to be new problems even building from source.

@markmandel
Copy link
Contributor

@XAMPPRocky heya! Back from time off - lemme take a look 👍🏻

@markmandel
Copy link
Contributor

Digging in a little - looks like test-examples is working (can confirm locally as well) - so you definitely got past hurdle No. 1.

The next thing that's failing is that it's not cross compiling to mac for us. Something is failing in the compilation of protoc on the rust-linux-darwin-builder image. I'm digging into it.

I'm seeing what I can find, but have also filed joseluisq/rust-linux-darwin-builder#20 to see if anyone else has any ideas 🤔

@markmandel
Copy link
Contributor

....I have an idea 😄

Adding a feature so that if you have a local protoc, it won't vendor. I think this will work.

@markmandel
Copy link
Contributor

Submitted #653 - I think this will solve the issue! (wil check if CI passes when I wake up tomorrow).

@github-actions github-actions bot added size/m and removed size/s labels Nov 30, 2022
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 8926a283-d614-4971-ba1f-90fa24401c21

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/651/head:pr_651 && git checkout pr_651
cargo build

@markmandel markmandel merged commit 1087416 into main Nov 30, 2022
@markmandel markmandel deleted the update-deps branch November 30, 2022 18:59
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants