Consistency of "packets_dropped_total" metric #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://prometheus.io/docs/practices/naming/#metric-names "A metric name should have a suffix describing the unit, in plural form Note that an accumulating count has `total` as a suffix, in addition to the unit if applicable." Therefore, all "packets_dropped" metric names should be "packet_dropped_total". This implements that change across all packets_dropped metric (which as far as I can tell is the only metric missing this suffix) for both the metric and variable name, which was sometimes implemented and sometimes not.
markmandel
added
area/operations
markmandel
requested review from
XAMPPRocky,
No-ops,
rezvaneh and
vallfors
as code owners
XAMPPRocky
approved these changes
Nov 4, 2022
|
Build Succeeded 🥳 Build Id: 1f6e9ff2-08bf-4de6-89a8-6ebaca8edc93 The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Per https://prometheus.io/docs/practices/naming/#metric-names
"A metric name should have a suffix describing the unit, in plural form Note that an accumulating count has
totalas a suffix, in addition to the unit if applicable."Therefore, all "packets_dropped" metric names should be "packet_dropped_total".
This implements that change across all packets_dropped metric (which as far as I can tell is the only metric missing this suffix) for both the metric and variable name, which was sometimes implemented and sometimes not.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A