Update yaml configuration documentation #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several updates to make the yaml configuration section easier to understand. * Renamed to "file configuration" * Connected the file configuration doc to "usage" rather than "proxy". * Add `admin` and `maxmind` section to proxy.yaml example * Add `max_mind` to json schema in docs * Include the two example config files to the file configuration documentation, so there are both examples and the schema to follow. Work on googleforgames#546
markmandel
added
kind/documentation
markmandel
requested review from
XAMPPRocky,
No-ops,
rezvaneh and
vallfors
as code owners
XAMPPRocky
approved these changes
Oct 28, 2022
|
Build Succeeded 🥳 Build Id: e7de701f-a709-4c19-b394-2af08d21aed9 The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Several updates to make the yaml configuration section easier to understand.
adminandmaxmindsection to proxy.yaml examplemax_mindto json schema in docsWhich issue(s) this PR fixes:
Work on #546
Special notes for your reviewer:
More documentation review to come, but this section was top of mind because Discord, so wanted to tackle it.