Try to recover when the main process fails #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
markmandel,
No-ops,
rezvaneh and
vallfors
as code owners
markmandel
reviewed
Oct 26, 2022
| Commands::Manage(manager) => tokio::spawn(async move { manager.manage(config).await }), | ||
| Commands::GenerateConfigSchema(generator) => { | ||
| tokio::spawn(std::future::ready(generator.generate_config_schema())) | ||
| let fut = tryhard::retry_fn({ |
There was a problem hiding this comment.
Shall we warn a log on retry?
XAMPPRocky
force-pushed
the
ep/recover-when-main-fails
branch
from
dad40b0 to
7bfc423
Compare
markmandel
approved these changes
Oct 27, 2022
|
Build Succeeded 🥳 Build Id: dc33e41f-80f5-4303-ab39-96edf54b9afd The following development images have been built, and will exist for the next 30 days: To build this version: |
markmandel
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spurious errors like #626
fixes #626