Agones: Add token removal test. #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to existing integration test that when a token annotation is removed from a `GameServer` record, it is also removed from the Quilkin endpoint configuration - thereby blocking access to the GameServer. Closes googleforgames#589
markmandel
added
area/tests
markmandel
requested review from
XAMPPRocky,
No-ops,
rezvaneh and
vallfors
as code owners
XAMPPRocky
approved these changes
Oct 25, 2022
|
Build Succeeded 🥳 Build Id: 4f46620e-7766-4033-a257-8aeefa1e1fac The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Added to existing integration test that when a token annotation is removed from a
GameServerrecord, it is also removed from the Quilkin endpoint configuration - thereby blocking access to the GameServer.Which issue(s) this PR fixes:
Closes #589
Special notes for your reviewer:
Getting close to what we need for a 0.4.0 release!