Add timestamp filter #627
Add timestamp filter #627
Conversation
XAMPPRocky
requested review from
markmandel,
No-ops,
rezvaneh and
vallfors
as code owners
XAMPPRocky
force-pushed
the
ep/metric-filter
branch
2 times, most recently
from
e826804 to
7172403
Compare
XAMPPRocky
force-pushed
the
ep/metric-filter
branch
from
7172403 to
18c6f41
Compare
|
|
||
| let now = Utc::now(); | ||
| let seconds = now.signed_duration_since(datetime).num_seconds(); | ||
| self.metric(direction_label).observe(seconds as f64); |
There was a problem hiding this comment.
(non blocking question): Does it make sense to combine this with maxmind information somehow? Either in the label or in tracing information?
Just thinking about tracking ping round trip times using this filter, and wanting some granularity on where geographically people are at?
There was a problem hiding this comment.
Does it make sense to combine this with maxmind information somehow? Either in the label or in tracing information?
Yes it does, I'm going to try to find a way to do purely through grafana before trying to integrate it directly in code.
|
Build Succeeded 🥳 Build Id: 3851df97-1abb-420a-aff9-8f51aa3ca08d The following development images have been built, and will exist for the next 30 days: To build this version: |
As soon as I hit merge on googleforgames#627 I realised that the docs weren't linked and I missed it on review! 🤦🏻♂️ So here are the fixes!
As soon as I hit merge on #627 I realised that the docs weren't linked and I missed it on review! 🤦🏻♂️ So here are the fixes!
markmandel
added
kind/feature
This adds a new timestamp filter that reads in a metadata value as a unix timestamp, and then observes the duration between then and now in a histogram metric that's keyed by the direction and metadata key. This is mainly useful in combination with things like
Capturewhich then allows you to parse timestamps from packets.