Refactor session metrics and errors #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
markmandel,
luna-duclos,
rezvaneh and
vallfors
as code owners
XAMPPRocky
commented
Sep 30, 2022
| @@ -70,5 +70,5 @@ async fn metrics_server() { | |||
|
|
|||
| let response = String::from_utf8(resp.to_vec()).unwrap(); | |||
| dbg!(&response); | |||
| assert!(response.contains("quilkin_session_tx_packets_total 1")); | |||
| assert!(response.contains(r#"quilkin_packets_total{event="read"} 2"#)); | |||
There was a problem hiding this comment.
This is now 2 because this test uses two Quilkin proxies.
Refactors session metrics to use static variables, this saves us 80 bytes per session (plus some more from being cloned down from proxy). The one downside is that I had to remove one test, because using static variables for metrics doesn't work well the with multithreaded tests. But the test was simple enough that I think it's worth losing that small bit of coverage. It also refactors session's errors to be more helpful, and include more information when logged. I did this through a through a trait so that later we can make it easier to log other errors and types without duplication. I also refactored the branches in the packet send code to ensure that `PACKETS_DROPPED` is always being incremented when we don't send packets.
XAMPPRocky
force-pushed
the
ep/refactor-session
branch
from
49e13fc to
8ab3ced
Compare
|
Build Succeeded 🥳 Build Id: 22f66bd6-203d-43f1-868f-9fcef11f3ac4 The following development images have been built, and will exist for the next 30 days: To build this version: |
markmandel
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
LGTM. Agreed it's a shame that we lose the coverage, but it's much cleaner, and will save us on passing through the date each time.
Not from this PR, but just making a note for later: packets_dropped should probably be packets_dropped_total, same with packets_size - just to have consistent naming (and I'm fairly sure that's the nomenclature for metrics).
XAMPPRocky
added a commit
that referenced
this pull request
Oct 10, 2022
Refactors session metrics to use static variables, this saves us 80 bytes per session (plus some more from being cloned down from proxy). The one downside is that I had to remove one test, because using static variables for metrics doesn't work well the with multithreaded tests. But the test was simple enough that I think it's worth losing that small bit of coverage. It also refactors session's errors to be more helpful, and include more information when logged. I did this through a through a trait so that later we can make it easier to log other errors and types without duplication. I also refactored the branches in the packet send code to ensure that `PACKETS_DROPPED` is always being incremented when we don't send packets.
XAMPPRocky
added a commit
that referenced
this pull request
Oct 10, 2022
Refactors session metrics to use static variables, this saves us 80 bytes per session (plus some more from being cloned down from proxy). The one downside is that I had to remove one test, because using static variables for metrics doesn't work well the with multithreaded tests. But the test was simple enough that I think it's worth losing that small bit of coverage. It also refactors session's errors to be more helpful, and include more information when logged. I did this through a through a trait so that later we can make it easier to log other errors and types without duplication. I also refactored the branches in the packet send code to ensure that `PACKETS_DROPPED` is always being incremented when we don't send packets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors session metrics to use static variables, this saves us 80 bytes per session (plus some more from being cloned down from proxy). The one downside is that I had to remove one test, because using static variables for metrics doesn't work well the with multithreaded tests. But the test was simple enough that I think it's worth losing that small bit of coverage.
It also refactors session's errors to be more helpful, and include more information when logged. I did this through a through a trait so that later we can make it easier to log other errors and types without duplication. I also refactored the branches in the packet send code to ensure that
PACKETS_DROPPEDis always being incremented when we don't send packets.