Add short poll to xDS clients as workaround, improve xDS tracing #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently for some reason the management server is not sending back to active clients changes because there is seemingly no receivers. This is a temporary workaround to have the client constantly polling for new changes so that will stay up to date, while we work on addressing the management's bi-directional communication.
XAMPPRocky
requested review from
markmandel,
luna-duclos,
rezvaneh,
vallfors and
bombsimon
as code owners
markmandel
approved these changes
Sep 26, 2022
|
Build Succeeded 🥳 Build Id: 4be830b5-36f0-4e37-a3f5-77f4acabb3ee The following development images have been built, and will exist for the next 30 days: To build this version: |
XAMPPRocky
added a commit
that referenced
this pull request
Oct 10, 2022
Currently for some reason the management server is not sending back to active clients changes because there is seemingly no receivers. This is a temporary workaround to have the client constantly polling for new changes so that will stay up to date, while we work on addressing the management's bi-directional communication. Co-authored-by: Mark Mandel <markmandel@google.com>
XAMPPRocky
added a commit
that referenced
this pull request
Oct 10, 2022
Currently for some reason the management server is not sending back to active clients changes because there is seemingly no receivers. This is a temporary workaround to have the client constantly polling for new changes so that will stay up to date, while we work on addressing the management's bi-directional communication. Co-authored-by: Mark Mandel <markmandel@google.com>
markmandel
added
area/operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for some reason the management server is not sending back to active clients changes because there is seemingly no receivers. This is a temporary workaround to have the client constantly polling for new changes so that will stay up to date, while we work on addressing the management's bi-directional communication.
This also improves some of the tracing for the xds stream to place relevant information in a span.