Docs, tests and bug fixes for /ready #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Documented /ready * Fixed bug with /ready with xDS provider, wherein a xDS provider would be marked as not ready if it has no endpoints -- which makes sense for a Proxy, but not for a xDS provider. * Implemented extra unit and integration tests Closes googleforgames#597
markmandel
added
kind/bug
markmandel
requested review from
XAMPPRocky,
luna-duclos,
rezvaneh,
vallfors and
bombsimon
as code owners
|
Build Succeeded 🥳 Build Id: 16c7c0b2-5ace-4b33-9f4c-d45215ae9ec0 The following development images have been built, and will exist for the next 30 days: To build this version: |
XAMPPRocky
approved these changes
Sep 24, 2022
XAMPPRocky
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Documented /ready * Fixed bug with /ready with xDS provider, wherein a xDS provider would be marked as not ready if it has no endpoints -- which makes sense for a Proxy, but not for a xDS provider. * Implemented extra unit and integration tests Closes #597
XAMPPRocky
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Documented /ready * Fixed bug with /ready with xDS provider, wherein a xDS provider would be marked as not ready if it has no endpoints -- which makes sense for a Proxy, but not for a xDS provider. * Implemented extra unit and integration tests Closes #597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #597
Special notes for your reviewer: