Add Build Images to CI results #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the image artifacts to successful builds. Since Cloud Build doesn't track pushed images on failure (and the image may/may not exist depending on where it failed) I can only provide directions on how to search for the image after the fact. Closes googleforgames#593
markmandel
force-pushed
the
ci/image-notification
branch
from
89a62db to
7f5e379
Compare
|
Build Succeeded 🥳 Build Id: b5f40bc2-3ac0-49fa-a799-d2637616e49a The following development images have been built, and will exist for the next 30 days: To build this version: |
markmandel
requested review from
XAMPPRocky,
luna-duclos,
rezvaneh,
vallfors and
bombsimon
as code owners
XAMPPRocky
approved these changes
Sep 22, 2022
XAMPPRocky
pushed a commit
that referenced
this pull request
Oct 10, 2022
XAMPPRocky
pushed a commit
that referenced
this pull request
Oct 10, 2022
markmandel
added
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Added the image artifacts to successful builds.
Since Cloud Build doesn't track pushed images on failure (and the image may/may not exist depending on where it failed) I can only provide directions on how to search for the image after the fact.
Which issue(s) this PR fixes:
Closes #593
Special notes for your reviewer:
Also updated the Go version, and now the CI container registry is public, so one can search for development images.
If you can think of any other improvements, please suggest them!