Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metric names in dashboard #595

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Fix metric names in dashboard #595

merged 2 commits into from
Sep 20, 2022

Conversation

XAMPPRocky
Copy link
Collaborator

fixes #588

@markmandel
Copy link
Contributor

Thank you!

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: dba466ab-c84c-4646-acac-29601a1a4d50

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/595/head:pr_595 && git checkout pr_595
cargo build

@markmandel markmandel merged commit 127e4af into main Sep 20, 2022
@markmandel markmandel deleted the fix-metric-names branch September 20, 2022 00:48
XAMPPRocky added a commit that referenced this pull request Sep 20, 2022
@XAMPPRocky @markmandel
Fix metric names in dashboard (#595)
9af65b8 
Co-authored-by: Mark Mandel <markmandel@google.com>
@markmandel markmandel mentioned this pull request Sep 26, 2022
Closed
XAMPPRocky added a commit that referenced this pull request Oct 10, 2022
@XAMPPRocky @markmandel
Fix metric names in dashboard (#595)
99029e0 
Co-authored-by: Mark Mandel <markmandel@google.com>
XAMPPRocky added a commit that referenced this pull request Oct 10, 2022
@XAMPPRocky @markmandel
Fix metric names in dashboard (#595)
b5e8a97 
Co-authored-by: Mark Mandel <markmandel@google.com>
@markmandel markmandel added kind/bug Something isn't working area/examples Examples. Usually found in the `examples` directory labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

@markmandel markmandel markmandel approved these changes

@luna-duclos luna-duclos Awaiting requested review from luna-duclos

@rezvaneh rezvaneh Awaiting requested review from rezvaneh

@vallfors vallfors Awaiting requested review from vallfors

Assignees
No one assigned
Labels
area/examples Examples. Usually found in the `examples` directory kind/bug Something isn't working size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics having no data after refactors.
4 participants
@XAMPPRocky @markmandel @quilkin-bot @bombsimon