Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allocated check for deleted gameserver events #594

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

XAMPPRocky
Copy link
Collaborator

This check was wrong and prevents Quilkin from removing stale endpoints unless it gets a restarted event.

@XAMPPRocky XAMPPRocky changed the title Remove allocated check for deleted events Remove allocated check for deleted gameserver events Sep 19, 2022
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 34894f16-b55a-4244-b583-f62b989b7e9e

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/594/head:pr_594 && git checkout pr_594
cargo build

@XAMPPRocky XAMPPRocky merged commit 7f508fd into main Sep 19, 2022
@XAMPPRocky XAMPPRocky deleted the ep/rm-check branch September 19, 2022 16:35
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/xds Related to Envoy xDS labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/xds Related to Envoy xDS kind/cleanup Refactoring code, fixing up documentation, etc size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants