Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LocalitySet type to ensure there aren't duplicate locality entries #592

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Add LocalitySet type to ensure there aren't duplicate locality entries #592

merged 1 commit into from
Sep 13, 2022

Conversation

XAMPPRocky
Copy link
Collaborator

fixes #585

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 54cb093a-7fd2-49ea-a704-2f88e8d8e73b

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/592/head:pr_592 && git checkout pr_592
cargo build

bombsimon
bombsimon approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the question for my own understanding.

src/cluster.rs Show resolved Hide resolved
@XAMPPRocky XAMPPRocky merged commit 4c8d860 into main Sep 13, 2022
@XAMPPRocky XAMPPRocky deleted the ep/locality-set branch September 13, 2022 14:43
XAMPPRocky added a commit that referenced this pull request Oct 10, 2022
@XAMPPRocky
Add LocalitySet type to ensure there aren't duplicate locality entries (
c28803c 
#592)
XAMPPRocky added a commit that referenced this pull request Oct 10, 2022
@XAMPPRocky
Add LocalitySet type to ensure there aren't duplicate locality entries (
f247ed7 
#592)
@markmandel markmandel added kind/bug Something isn't working area/xds Related to Envoy xDS labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

@markmandel markmandel Awaiting requested review from markmandel

@luna-duclos luna-duclos Awaiting requested review from luna-duclos

@rezvaneh rezvaneh Awaiting requested review from rezvaneh

@vallfors vallfors Awaiting requested review from vallfors

Assignees
No one assigned
Labels
area/xds Related to Envoy xDS kind/bug Something isn't working size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xDS: Locality leak on GameServer event handling
4 participants
@XAMPPRocky @quilkin-bot @bombsimon @markmandel