Add client proxy load balancing support #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
area/user-experience
This commit adds RoundRobin and Random load balancing support to a proxy as well as config support for multiple addresses and load balancer policy on the client proxy config. The default behavior if no policy is set or is a server proxy sends packets to all endpoints. This also introduces the `rand` crate as a dependency, used by the random load balancing implementation. Resolves #3
iffyio
force-pushed
the
iu/load-balancer-policy
branch
from
485cce8 to
17b3998
Compare
markmandel
reviewed
Jun 3, 2020
| pub enum LoadBalancerPolicy { | ||
| /// Send all traffic to all endpoints. | ||
| #[serde(rename = "BROADCAST")] | ||
| Broadcast, |
| @@ -69,8 +64,9 @@ pub enum ConnectionConfig { | |||
| /// Client is the configuration for a client proxy, for sitting behind a game client. | |||
| #[serde(rename = "client")] | |||
| Client { | |||
| address: SocketAddr, | |||
| addresses: Vec<SocketAddr>, | |||
There was a problem hiding this comment.
I think it would be good to also update https://github.com/googleforgames/quilkin/blob/master/examples/client-proxy.yaml, since that is the closest thing we have to docs right now.
(We should really write some docs 😃 )
There was a problem hiding this comment.
Updated the examples config!
| /// EndpointChooser chooses from a set of endpoints that a proxy is connected to. | ||
| trait EndpointChooser: Send + Sync { | ||
| /// choose_endpoints asks for the next endpoint(s) to use. | ||
| fn choose_endpoints(&self) -> Vec<EndPoint>; |
| .choose_endpoints() | ||
| .iter() | ||
| .map(|e| e.address) | ||
| .collect::<Vec<_>>()) |
markmandel
reviewed
Jun 4, 2020
src/load_balancer_policy.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// RandomEndpointChooser chooses endpoints in round-robin order. |
There was a problem hiding this comment.
Suggested change
| /// RandomEndpointChooser chooses endpoints in round-robin order. | |
| /// RandomEndpointChooser chooses endpoints in a random order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds RoundRobin and Random load balancing
support to a proxy as well as config support for multiple
addresses and load balancer policy on the client proxy config.
The default behavior if no policy is set or is a server proxy
sends packets to all endpoints.
This also introduces the
randcrate as a dependency, used bythe random load balancing implementation.
Resolves #3