Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of licences and advisories #550

Merged

Conversation

markmandel
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

  • We no longer ship any MPL licenced content, so removed it, since if we
    do encounter it again, it should be included with the image as source.
  • We don't have any CC0-1.0 either, so removed it.
  • The advisories that we were ignoring, are no longer an issue, so
    removed as well.
  • No longer using slog-json, so removed that exception.
  • Added Unicode-DFS-2016 as an allowed licence, since unicode-ident
    is using it in a latest release.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

* We no longer ship any MPL licenced content, so removed it, since if we
 do encounter it again, it should be included with the image as source.
* We don't have any CC0-1.0 either, so removed it.
* The advisories that we were ignoring, are no longer an issue, so
removed as well.
* No longer using slog-json, so removed that exception.
* Added `Unicode-DFS-2016` as an allowed licence, since `unicode-ident`
 is using it in a latest release.
@markmandel markmandel added area/tests Unit tests, integration tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. labels Jul 21, 2022
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 98dacaf2-3aa3-48ce-b1b7-ec9c01ad1cd5

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/550/head:pr_550 && git checkout pr_550
cargo build

@markmandel markmandel merged commit d484378 into googleforgames:main Jul 21, 2022
@markmandel markmandel deleted the cleanup/licence-advisories branch July 21, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. area/tests Unit tests, integration tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants