Implementation of local_send_filter

[markmandel]

Implementation plus unit tests!

Work on #1

[iffyio]

LGTM!

[iffyio]

wondering if this might be simpler unwraping the result since we're not verifying this part e.g send_packet.send(...).await.unwrap();? or if the result isn't debuggable, asserting that it's ok e.g assert!(send_packet.send(...).await.is_ok());? I'm not sure either makes it more ergonomic tbh so feel free to leave as is.

[markmandel]

Hmnn, that's a good point. Lemme try the unwrap() that would seem like it would be simpler.

[markmandel]

Ah! So there is no unwrap:

error[E0599]: no method named `unwrap` found for enum `std::result::Result<(), tokio::sync::mpsc::error::SendError<server::sessions::Packet>>` in the current scope
   --> src/server/server.rs:621:14
    |
621 |             .unwrap();
    |              ^^^^^^ method not found in `std::result::Result<(), tokio::sync::mpsc::error::SendError<server::sessions::Packet>>`
    |
    = note: the method `unwrap` exists but the following trait bounds were not satisfied:
            `tokio::sync::mpsc::error::SendError<server::sessions::Packet> : std::fmt::Debug`

So I think we can leave it as it is.

[markmandel]

Ah, I think this is a tad nicer -

        send_packet
            .send(Packet::new(local_addr, msg.as_bytes().to_vec()))
            .await
            .map_err(|err| assert!(false, err))
            .unwrap();

WDYT?

[iffyio]

Agree, this is nicer!