Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General testing cleanup #539

Merged
merged 1 commit into from
Jun 9, 2022
Merged

General testing cleanup #539

merged 1 commit into from
Jun 9, 2022

Conversation

markmandel
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

  • Remove hardcoded ports, and dynamically assign available ephemeral ports
  • Remove redundancy/consolidate some tests
  • Remove unneeded dependency for creating a socket from TestHelper
  • Add timeout(...) everywhere, to avoid test deadlocks on future failures.
  • Other small tweaks here and there.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

@markmandel markmandel added area/tests Unit tests, integration tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Jun 4, 2022
@github-actions github-actions bot added the size/m label Jun 4, 2022
bombsimon
bombsimon approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@markmandel
General testing cleanup
6846b79 
* Remove hardcoded ports, and dynamically assign available ephemeral
ports
* Remove redundancy/consolidate some tests
* Remove unneeded dependency for creating a socket from `TestHelper`
* Add `timeout(...)` everywhere, to avoid test deadlocks on future
failures.
* Other small tweaks here and there.
@markmandel markmandel force-pushed the cleanup/integration-tests branch from 6493473 to 6846b79 Compare June 9, 2022 19:23
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: b50567ed-6648-4eab-8684-f04196a8a491

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/539/head:pr_539 && git checkout pr_539
cargo build

@markmandel markmandel merged commit 7acd92f into googleforgames:main Jun 9, 2022
@markmandel markmandel deleted the cleanup/integration-tests branch June 9, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

@XAMPPRocky XAMPPRocky Awaiting requested review from XAMPPRocky XAMPPRocky is a code owner

@luna-duclos luna-duclos Awaiting requested review from luna-duclos

@rezvaneh rezvaneh Awaiting requested review from rezvaneh

Assignees
No one assigned
Labels
area/tests Unit tests, integration tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @quilkin-bot @bombsimon