connect() Sessions socket to Endpoint address
#538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a Session is only ever going to send data to the Endpoint, we can `connect()` the socket to that address, rather than need to pass the endpoint address to every `send()` request.
markmandel
added
kind/cleanup
markmandel
requested review from
XAMPPRocky,
luna-duclos,
rezvaneh and
bombsimon
as code owners
bombsimon
approved these changes
Jun 9, 2022
|
Build Succeeded 🥳 Build Id: fd3623fa-c524-40f5-a8b3-4d885f03c6e9 To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Since a Session is only ever going to send data to the Endpoint, we can
connect()the socket to that address, rather than need to pass the endpoint address to everysend()request.Which issue(s) this PR fixes:
Cleanup with working on #410
Special notes for your reviewer:
N/A