-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor configuration and builder pattern #525
Conversation
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
6a80ed0
to
fdc0ff6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fdc0ff6
to
396d403
Compare
This comment was marked as outdated.
This comment was marked as outdated.
396d403
to
8084e28
Compare
This comment was marked as outdated.
This comment was marked as outdated.
8084e28
to
6fb0bd3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Build Succeeded 🥳 Build Id: 03c78f04-8d47-4439-a51c-0155baa9ad0d To build this version:
|
This PR updates Quilkin's configuration to be more dynamic friendly, and to allow for the configuration to contain not just
static
ordynamic
, but instead makeendpoints
,filters
, andmanagement_servers
each optional fields which allows for us to reuse the same configuration on the xDS server side as we would on the Quilkin client side. The only change in behaviour here is that you can now set Quilkin's initial state before it connects to the management servers.Breaking Changes
static
anddynamic
properties inConfig
, instead replacing them withendpoints
,filters
, andmanagement_servers
directly.proxy::Builder
, instead constructingServer
fromConfig
directly.closes #520