Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor configuration and builder pattern #525

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

XAMPPRocky
Copy link
Collaborator

@XAMPPRocky XAMPPRocky commented Apr 26, 2022

This PR updates Quilkin's configuration to be more dynamic friendly, and to allow for the configuration to contain not just static or dynamic, but instead make endpoints, filters, and management_servers each optional fields which allows for us to reuse the same configuration on the xDS server side as we would on the Quilkin client side. The only change in behaviour here is that you can now set Quilkin's initial state before it connects to the management servers.

Breaking Changes

  • Removed static and dynamic properties in Config, instead replacing them with endpoints, filters, and management_servers directly.
  • Removed proxy::Builder, instead constructing Server from Config directly.

closes #520

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link
Collaborator

@rezvaneh rezvaneh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@XAMPPRocky XAMPPRocky added the kind/breaking Changes to functionality, API, etc. label Apr 26, 2022
@github-actions

This comment was marked as outdated.

Copy link
Contributor

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 03c78f04-8d47-4439-a51c-0155baa9ad0d

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/525/head:pr_525 && git checkout pr_525
cargo build

@XAMPPRocky XAMPPRocky merged commit 41bbec2 into main Apr 26, 2022
@markmandel markmandel deleted the ep/config-refactor branch May 18, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking Changes to functionality, API, etc. size/xl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make config::Config compatible with xDS manager
4 participants