Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extensions from filter identifiers #484

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Remove extensions from filter identifiers #484

merged 1 commit into from
Feb 24, 2022

Conversation

XAMPPRocky
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #291

Special notes for your reviewer:

@github-actions github-actions bot added the size/l label Feb 4, 2022
@XAMPPRocky XAMPPRocky force-pushed the filter-rename branch 2 times, most recently from 76920f3 to 247f594 Compare February 4, 2022 23:36
@github-actions github-actions bot added size/m and removed size/l labels Feb 4, 2022
@XAMPPRocky XAMPPRocky force-pushed the filter-rename branch 3 times, most recently from ef721f3 to bb782b3 Compare February 5, 2022 00:14
@XAMPPRocky XAMPPRocky added the kind/breaking Changes to functionality, API, etc. label Feb 23, 2022
@markmandel markmandel mentioned this pull request Feb 23, 2022
Closed
markmandel
markmandel approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when conflicts are resolved 👍🏻

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 063c44ad-008b-4f6a-84ed-b176d5bcbc9e

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/484/head:pr_484 && git checkout pr_484
cargo build

@XAMPPRocky XAMPPRocky merged commit 999a885 into main Feb 24, 2022
@XAMPPRocky XAMPPRocky deleted the filter-rename branch February 24, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
kind/breaking Changes to functionality, API, etc. size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter Naming Scheme
3 participants
@XAMPPRocky @quilkin-bot @markmandel