Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to xds sample from xDS guide #470

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

markmandel
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Realised that there was no link to the xDS control plane example that we have, so added a section in the xDS guide.

Since I was in here, also took the liberty to move the headings to be semantically leveled.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Realised that there was no link to the xDS control plane example that we
have, so added a section in the xDS guide.

Since I was in here, also took the liberty to move the headings to be
semantically leveled.
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 10b164c7-b4b3-4d8e-a248-151b52762d6b

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/470/head:pr_470 && git checkout pr_470
cargo build

@XAMPPRocky XAMPPRocky merged commit 2c173ec into googleforgames:main Jan 14, 2022
@markmandel markmandel deleted the docs/xds-link branch January 18, 2022 18:45
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Improvements or additions to documentation labels Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Improvements or additions to documentation size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants