management-server: update metrics and doc #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds some new metrics to the management server - Add metrics to the documentation - Update documentation to show the kubernetes docs first since that's the primary binary. Followed by the file implementation.
XAMPPRocky
approved these changes
Jan 13, 2022
markmandel
reviewed
Jan 13, 2022
| > use, the server looks for the port named `default` and picks that as the endpoint's | ||
| > port (otherwise it picks the first port in the port list). | ||
|
|
||
| 1. Filter chain is configurable on a per-proxy basis. By default an empty filter chain is |
There was a problem hiding this comment.
Since we're in here, shall we also document the usage of the annotation of quilkin.dev/tokens ?
quilkin/xds/pkg/cluster/agones/agones.go
Line 138 in b32e48a
markmandel
approved these changes
Jan 18, 2022
|
Failure not related to the PR - looks like the Google Snappy package removed their github pages. Filing a PR shortly. |
Merged
|
Build Succeeded 🥳 Build Id: 38b07ab7-1272-429c-83a4-da670ec788c6 To build this version: |
markmandel
added
kind/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since that's the primary binary. Followed by the file
implementation.