Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: delete snapshot for disconnected proxies #462

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Conversation

iffyio
Copy link
Collaborator

@iffyio iffyio commented Jan 10, 2022

When proxies disconnect this clears their snapshot from
the cache. It periodically checks for snapshots that have
open watches (i.e has a proxy waiting for an update) and
if a snapshot seems idle after a while (the proxy isn't likely
to reconnect) it removes it from the cache.

When proxies disconnect this clears their snapshot from
the cache. It periodically checks for snapshots that have
open watches (i.e has a proxy waiting for an update) and
if a snapshot seems idle after a while (the proxy isn't likely
to reconnect) it removes it from the cache.
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: ba432b75-169a-4576-8d41-e0695cf3cf48

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/462/head:pr_462 && git checkout pr_462
cargo build

@iffyio iffyio marked this pull request as ready for review January 10, 2022 15:35
Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice stuff!

@iffyio iffyio merged commit 5c19e09 into main Jan 11, 2022
@iffyio iffyio deleted the iu/xds-snapshot-cleanup branch January 11, 2022 12:42
@markmandel markmandel added the kind/bug Something isn't working label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants