-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completely remove slog
and replace with tracing
#457
Conversation
slog
and replace with tracing
74bd9e8
to
9f58980
Compare
9f58980
to
c0bea7a
Compare
@markmandel Failure seems unrelated to the PR, not sure how to fix it. |
That's a weird one. When in doubt, retry. |
Looks like I can't re-run a build older than three days. Easy way to rerun a build if you don't want to go to the console is: |
@markmandel FWIW, I wrote that comment after retrying twice. I'll push an empty commit in the next couple days (on holidays) |
AAAH. I can't tell anymore, because no history 😄 Sounds like I'll need try this locally and see if I can find where things are broken in the build system 👍🏻 No worries, I'll get on it tomorrow most likely. |
I worked it out! Since we no longer have slog-json, we don't have any MPL source code to grab, so the zip doesn't get created! I'll come up with a fix in my draft branch, and you can include it in the PR 👍🏻 |
Got it! You will need to update I figure it would make more sense to be included in your PR, since the removal of |
If there are no dependencies utilised that we need to archive source for, this breaks the build process since no dependencies-src.zip file is created, and the Dockerfile has nothing to copy. This changes the script such that it starts with an empty zip file, and then appends dependencies if and when they exist. Unblocks googleforgames#457
If there are no dependencies utilised that we need to archive source for, this breaks the build process since no dependencies-src.zip file is created, and the Dockerfile has nothing to copy. This changes the script such that it starts with an empty zip file, and then appends dependencies if and when they exist. Unblocks #457
Build Succeeded 🥳 Build Id: e7e504fd-899d-457c-9528-72cee2e7ac61 To build this version:
|
With the release of https://github.com/tokio-rs/console I wanted to move over to tracing sooner rather than later, so this pulls out all instances of
slog
and replaces them withtracing
.resolves #317