Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug archiving dependencies #442

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

markmandel
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

If there are ever multiple versions of a dependency in $CARGO_HOME the archive_dependencies.sh script would fail.

This fixes this issue.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

If there are ever multiple versions of a dependency in $CARGO_HOME the
`archive_dependencies.sh` script would fail.

This fixes this issue.
@markmandel markmandel added kind/bug Something isn't working area/build-tools Development tooling. labels Nov 23, 2021
@google-cla google-cla bot added the cla: yes label Nov 23, 2021
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 92ad81d7-52d3-4054-9b31-90250aef0c4d

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/442/head:pr_442 && git checkout pr_442
cargo build

@markmandel markmandel merged commit 97a9fa0 into googleforgames:main Nov 24, 2021
@markmandel markmandel deleted the bug/dependency-zip branch November 24, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. cla: yes kind/bug Something isn't working size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants