Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Tokio for RUSTSEC-2021-0124 #439

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

markmandel
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Upgraded Tokio and related crates to resolve the security advisory.

https://rustsec.org/advisories/RUSTSEC-2021-0124.html

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Hit me while testing locally, but has yet to hit CI as of yet? Either way, better to get in front of it.

@markmandel markmandel added the area/security Issues pertaining to security label Nov 17, 2021
@google-cla google-cla bot added the cla: yes label Nov 17, 2021
Upgraded Tokio and related crates to resolve the security advisory.

https://rustsec.org/advisories/RUSTSEC-2021-0124.html
@markmandel
Copy link
Contributor Author

🤔 hmnn. Struggling to reproduce this locally. How odd.

@markmandel
Copy link
Contributor Author

Aha!

make: *** [Makefile:65: test-examples] Error 101 - I should read my own error messages!

@markmandel markmandel force-pushed the security/update-tokio branch from 4c6fb9a to a9bd1a8 Compare November 17, 2021 19:52
@XAMPPRocky XAMPPRocky merged commit 5bf35a8 into googleforgames:main Nov 17, 2021
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 1dd54cec-86f3-4053-9fd4-3578615993d8

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/439/head:pr_439 && git checkout pr_439
cargo build

@markmandel markmandel deleted the security/update-tokio branch November 17, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Issues pertaining to security cla: yes size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants