Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reqwest from dev-dependencies #429

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Remove reqwest from dev-dependencies #429

merged 1 commit into from
Oct 28, 2021

Conversation

XAMPPRocky
Copy link
Collaborator

This PR removes reqwest from our dev-dependencies and replaces it with using hyper directly. This removes a number of dependencies that were only present with reqwest and on my machine reduces the total time for clean debug builds by five seconds. Dependency graphs generated with cargo-depgraph.

With Reqwest



cargo build --all --tests  226.34s user 21.31s system 445% cpu 55.542 total

graph-reqwest

No Reqwest

cargo build --all --tests  220.04s user 20.43s system 472% cpu 50.937 total

graph

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: e4265865-f2eb-43b1-ac4a-f5870502404b

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/429/head:pr_429 && git checkout pr_429
cargo build

@markmandel markmandel merged commit 1f80577 into main Oct 28, 2021
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 28, 2021
@markmandel markmandel deleted the rm-reqwest branch November 18, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants