Fix duplicate metric registration for filters #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some filter currently call `register` (rather than `register_if_not_exists`) which throws an error if the metric has already been registered - this meant that we couldn't use multiple instances of those filter in the filter chain
XAMPPRocky
approved these changes
Sep 19, 2021
Comment on lines
+49
to
+56
| fn register_metric<T: Collector + Sized + 'static>( | ||
| registry: &Registry, | ||
| collector: T, | ||
| ) -> Result<()> { | ||
| registry.register(Box::new(collector)) | ||
| } | ||
|
|
||
| pub trait CollectorExt: Collector + Clone + Sized + 'static { |
|
@markmandel we can also include this fix in the upcoming release? |
Let's do it! Going to start the release today, so this sneaks in nicely! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some filter currently call
register(rather thanregister_if_not_exists) which throws an error if the metrichas already been registered - this meant that we couldn't use
multiple instances of those filter in the filter chain