Exit on SIGTERM #393
Merged
Exit on SIGTERM #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we currently only listen for SIGINT while k8s sends a SIGTERM to shutdown a process, so we need to listen for that too
markmandel
reviewed
Sep 7, 2021
src/runner.rs
Outdated
| let sig_term = sig_term_fut.recv(); | ||
| tokio::select! { | ||
| _ = signal::ctrl_c() => { | ||
| info!(signal_log, "Received SIGINT") |
There was a problem hiding this comment.
Mega nit: Should this be debug!? Not sure if production really cares which signal it gets?
Otherwise, this is a great catch 👍🏻
XAMPPRocky
approved these changes
Sep 8, 2021
markmandel
approved these changes
Sep 8, 2021
|
(Totally random - but why is the notification bot not working for this PR?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we currently only listen for SIGINT while k8s sends
a SIGTERM to shutdown a process, so we need to listen for that
too