Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup other parts of the public API. #308

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Cleanup other parts of the public API. #308

merged 1 commit into from
Aug 6, 2021

Conversation

XAMPPRocky
Copy link
Collaborator

This now makes the proxy and runner private modules as they don't really provide much for users of the library as the proxy and the runner could both be considered Quilkin. So their types are now exported at the top-level. So instead of quilkin::runner::run(…) it's quilkin::run(…) for "running Quilkin", and it's quilkin::Builder instead of quilkin::proxy::Builder, as you're building a Quilkin server. This is how the top-level docs looks like with these changes.

Screenshot 2021-06-30 at 09 37 01

@XAMPPRocky XAMPPRocky requested review from markmandel and iffyio June 30, 2021 10:36
@google-cla google-cla bot added the cla: yes label Jun 30, 2021
@quilkin-bot

This comment has been minimized.

@quilkin-bot

This comment has been minimized.

@XAMPPRocky XAMPPRocky added this to the Release milestone Jul 5, 2021
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 7e106e32-1728-418b-a718-36dd9bb92dd2

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/308/head:pr_308 && git checkout pr_308
cargo build

@XAMPPRocky XAMPPRocky removed this from the Release milestone Jul 12, 2021
@iffyio
Copy link
Collaborator

iffyio commented Jul 21, 2021

Is this PR good to review? I'm a bit unsure what's what because from a quick look I could have sworn I had reviewed the changes in another PR 😄

@XAMPPRocky
Copy link
Collaborator Author

Is this PR good to review? I'm a bit unsure what's what because from a quick look I could have sworn I had reviewed the changes in another PR 😄

That's because it includes #293, for the specific changes in this PR, it's in this commit.

0d07c3f

@quilkin-bot
Copy link
Collaborator

Build Failed 😭

Build Id: f63b6fd7-ce9c-464b-8639-abe7dbdbb1ef

Status: FAILURE

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

@quilkin-bot
Copy link
Collaborator

Build Failed 😭

Build Id: e651969c-8233-4a8c-9c6d-c8d3fff3b817

Status: FAILURE

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 7c99e32b-fcaf-4d63-b094-272404bf756a

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/308/head:pr_308 && git checkout pr_308
cargo build

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 92712420-ecca-4c88-a1d7-0d10cec34a34

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/308/head:pr_308 && git checkout pr_308
cargo build

Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major objections on my end, looks like a nice cleanup to pull the public API up a level.

Just looks like it's blocked on a few other PRs that are also merged into this one.

@iffyio any issues on your end?

.github/workflows/docs.yml Outdated Show resolved Hide resolved
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 169a5c46-b6fc-4f37-9ebd-4755dfdd67fb

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/308/head:pr_308 && git checkout pr_308
cargo build

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 22756e5f-c4bc-4ffa-b616-4e3b5f8f5fac

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/308/head:pr_308 && git checkout pr_308
cargo build

@XAMPPRocky XAMPPRocky merged commit 8d80b4c into main Aug 6, 2021
@markmandel markmandel deleted the small-cleanup branch August 17, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants