-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup other parts of the public API. #308
Conversation
This comment has been minimized.
This comment has been minimized.
f1df36d
to
8c2155d
Compare
This comment has been minimized.
This comment has been minimized.
Build Succeeded 🥳 Build Id: 7e106e32-1728-418b-a718-36dd9bb92dd2 To build this version:
|
Is this PR good to review? I'm a bit unsure what's what because from a quick look I could have sworn I had reviewed the changes in another PR 😄 |
0d07c3f
to
929cff7
Compare
Build Failed 😭 Build Id: f63b6fd7-ce9c-464b-8639-abe7dbdbb1ef Status: FAILURE To get permission to view the Cloud Build view, join the quilkin-discuss Google Group. |
929cff7
to
8bdbd38
Compare
Build Failed 😭 Build Id: e651969c-8233-4a8c-9c6d-c8d3fff3b817 Status: FAILURE To get permission to view the Cloud Build view, join the quilkin-discuss Google Group. |
8bdbd38
to
fa8e3a1
Compare
Build Succeeded 🥳 Build Id: 7c99e32b-fcaf-4d63-b094-272404bf756a To build this version:
|
fa8e3a1
to
4db7366
Compare
Build Succeeded 🥳 Build Id: 92712420-ecca-4c88-a1d7-0d10cec34a34 To build this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major objections on my end, looks like a nice cleanup to pull the public API up a level.
Just looks like it's blocked on a few other PRs that are also merged into this one.
@iffyio any issues on your end?
4db7366
to
3e9cfc2
Compare
Build Succeeded 🥳 Build Id: 169a5c46-b6fc-4f37-9ebd-4755dfdd67fb To build this version:
|
3e9cfc2
to
5cce761
Compare
Build Succeeded 🥳 Build Id: 22756e5f-c4bc-4ffa-b616-4e3b5f8f5fac To build this version:
|
This now makes the
proxy
andrunner
private modules as they don't really provide much for users of the library as theproxy
and therunner
could both be considered Quilkin. So their types are now exported at the top-level. So instead ofquilkin::runner::run(…)
it'squilkin::run(…)
for "running Quilkin", and it'squilkin::Builder
instead ofquilkin::proxy::Builder
, as you're building a Quilkin server. This is how the top-level docs looks like with these changes.