-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example Grafana dashboard for Quilkin Metrics #300
Conversation
Created setup scripts (Makefile) and a sample dashboard (screenshot in this commit) to show off some of Quilkin's expected metrics. Over time this can be expanded to include more panels in this dashboard, and other dashboards as well 👍🏻 At this stage, stayed away from Filter specific metrics, so that we have something that works out of the box, and can be expanded as needed. Closes #234
Build Succeeded 🥳 Build Id: 5cfc3877-c55d-49c1-893a-d1383474c858 To build this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The dashboard image is currently checked-in https://github.com/googleforgames/quilkin/blob/2d3fda86b16dd3f88ef1f22a04cacb7901ede1dd/examples/grafana-dashboards/quilkin-general.png was that a mistake? It doesn't seem useful otherwise?
Yep - It's inline with the README.md so you can see a demo of the dashboard without having to install it. I think it's also nice if you want to see a visualisation of the metrics of Quilkin without having to get it up and running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM! |
High praise indeed! 😄 |
Build Succeeded 🥳 Build Id: 43e16d1e-2bdb-41c5-ab0b-cffa98859460 To build this version:
|
Created setup scripts (Makefile) and a sample dashboard (screenshot in this commit) to show off some of Quilkin's expected metrics.
Over time this can be expanded to include more panels in this dashboard, and other dashboards as well 👍🏻
At this stage, stayed away from Filter specific metrics, so that we have something that works out of the box, and can be expanded as needed.
Closes #234
This is my first Grafana dashboard! So would love any kind of review or critique. I based this pretty heavily on existing Agones dashboards for techniques and approaches, so hopefully they aren't out of date 😄