Use 2018 mod style #277
Merged
Use 2018 mod style #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Succeeded 🥳 Build Id: 9a0a0369-6309-46d5-8b9f-293f5f7fa17f To build this version: |
iffyio
reviewed
May 26, 2021
There was a problem hiding this comment.
at least for filters, I'm thinking it makes sense to have the same layout for all filters in the repo -and keep the flexibility available for more complex filters that might want to do e.g src/extensions/filters/compress/metrics.rs rather than force cramming all srcs into the same mod.rs file. wdyt?
btw is there something in the rust docs on the rationale for preferring mod.rs?
markmandel
approved these changes
May 26, 2021
iffyio
approved these changes
May 26, 2021
|
Gentle bump to clear up the conflicts please 😄 |
|
Build Succeeded 🥳 Build Id: d029bb3a-9d56-461e-83fa-706d682ba213 To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to using the module style recommended in the 2018 edition, no other changes.