Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject config if it contains unknown fields #274

Merged
merged 2 commits into from
May 23, 2021
Merged

Reject config if it contains unknown fields #274

merged 2 commits into from
May 23, 2021

Conversation

iffyio
Copy link
Collaborator

@iffyio iffyio commented May 22, 2021

This should catch things like typos in configs and help ensure
the config examples in docs are are up to date

@iffyio
Reject config if it contains unknown fields
aee7ad6 
This should catch things like typos in configs and help ensure
the config examples in docs are are up to date
@iffyio iffyio requested review from markmandel and XAMPPRocky May 22, 2021 07:46
@google-cla google-cla bot added the cla: yes label May 22, 2021
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: ae894beb-eb9a-44e8-a01f-cb171eee6670

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/274/head:pr_274 && git checkout pr_274
cargo build

@markmandel markmandel merged commit cea499c into main May 23, 2021
@markmandel markmandel deleted the iu/config-deny-unused branch May 23, 2021 01:54
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, integration tests, anything to make sure things don't break labels May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@XAMPPRocky XAMPPRocky Awaiting requested review from XAMPPRocky XAMPPRocky is a code owner

Assignees
No one assigned
Labels
area/tests Unit tests, integration tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iffyio @quilkin-bot @markmandel