Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Github notification bot. #264

Merged
merged 1 commit into from
May 19, 2021
Merged

Implement Github notification bot. #264

merged 1 commit into from
May 19, 2021

Conversation

markmandel
Copy link
Contributor

Using https://github.com/GoogleCloudPlatform/cloud-build-notifiers as a base, created a Github bot that will add the details of the Google Cloud build to each pull request.

Closes #259

@markmandel markmandel added area/meta Organisational matters. e.g. Governance, release cycles, etc. area/build-tools Development tooling. labels May 18, 2021
@google-cla google-cla bot added the cla: yes label May 18, 2021
@markmandel markmandel marked this pull request as draft May 18, 2021 22:12
@markmandel markmandel force-pushed the mm/github-bot branch 3 times, most recently from ff09afb to 16683ef Compare May 18, 2021 23:09
@quilkin-bot

This comment has been minimized.

Sign in to view
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: b43367af-d960-46d2-872d-db1b954e9f33

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/264/head:pr_264 && git checkout pr_264
cargo build

@quilkin-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 909b831a-ba69-473c-8134-62b3918a6a6d

Status: FAILURE

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

@quilkin-bot
Copy link
Collaborator

Build Failed 😭

Build Id: d0a04cf6-dc4d-4ed7-9140-81bb8ceadaa8

Status: FAILURE

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

@quilkin-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 95014c80-adf7-4bf1-aa7d-a3ba4cfb7ed7

Status: FAILURE

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

@markmandel markmandel marked this pull request as ready for review May 19, 2021 00:39
@markmandel
Copy link
Contributor Author

markmandel commented May 19, 2021 •
edited
Loading

This should be good to go now.

I know the Cloud Build log download link points to an empty file. This is due to cloud build very rarely loosing it's build logs. It should resolve itself shortly, although might not fix the previous builds.

@quilkin-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 40e7616a-ae4a-4be5-84aa-22d20f44d538

Status: FAILURE

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

@markmandel
Copy link
Contributor Author

Looks like Cloud Build is having a minor outage atm. Wheee.

@quilkin-bot
Copy link
Collaborator

Build Failed 😭

Build Id: a6b6deb3-2103-4294-9848-0bf3554547a0

Status: CANCELLED

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

@quilkin-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 518e78fa-4c49-4c4b-aa2c-7c1e195843e0

Status: FAILURE

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

@XAMPPRocky
Copy link
Collaborator

Seems like it's commenting twice, is it being triggered on both push and pr events maybe? #262 (comment)

@XAMPPRocky
Copy link
Collaborator

Also would be nice if it hid its previous comment when you push to a PR.

@markmandel
Copy link
Contributor Author

Seems like it's commenting twice, is it being triggered on both push and pr events maybe? #262 (comment)

It comments on each build, so yes, it will comment on each push, since each push is a build.

Also would be nice if it hid its previous comment when you push to a PR.

Ooh, that's an interesting idea. Can we file that as a separate ticket?

@XAMPPRocky XAMPPRocky mentioned this pull request May 19, 2021
Closed
@markmandel
Implement Github notification bot.
5958f67 
Using https://github.com/GoogleCloudPlatform/cloud-build-notifiers as
a base, created a Github bot that will add the details of the Google
Cloud build to each pull request.

Closes #259
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 7d46250f-f9c1-4cd9-adef-cd63912155a3

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/264/head:pr_264 && git checkout pr_264
cargo build

@markmandel markmandel merged commit 3fc0a94 into main May 19, 2021
@markmandel markmandel deleted the mm/github-bot branch May 19, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iffyio iffyio iffyio approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. area/meta Organisational matters. e.g. Governance, release cycles, etc. cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write a github PR comment notifier for cloudbuilds
4 participants
@markmandel @quilkin-bot @XAMPPRocky @iffyio