Debug Filter: Capitalise log statement. #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Apr 6, 2021
src/extensions/filters/debug.rs
Outdated
| @@ -102,7 +102,7 @@ impl FilterFactory for DebugFactory { | |||
|
|
|||
| impl Filter for Debug { | |||
| fn read(&self, ctx: ReadContext) -> Option<ReadResponse> { | |||
| info!(self.log, "on local receive"; "from" => ctx.from, "contents" => packet_to_string(ctx.contents.clone())); | |||
| info!(self.log, "On local receive"; "from" => ctx.from, "contents" => packet_to_string(ctx.contents.clone())); | |||
There was a problem hiding this comment.
The log message seems outdated from when we had on_local_receive rather than read, we should probably update it as well?
There was a problem hiding this comment.
Excellent point 👍🏻 Lemme fix that up too.
Just a bit of cleanup the log statements to align with the new Filter format.
markmandel
force-pushed
the
mm/admin-server
branch
from
d4a55f4 to
1eb113f
Compare
iffyio
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bit of cleanup on a log statement.