Add xDS metrics #195
Merged
Add xDS metrics #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
reviewed
Feb 23, 2021
| } | ||
| } | ||
| err => { | ||
| error!(log, "error processing receive socket: {:?}", err); | ||
| // Socket error, we cannot recover from this so return an error instead. |
There was a problem hiding this comment.
Is this new breakout on error stuff related to the metrics work, or separate?
There was a problem hiding this comment.
It was separate, started off wanting to add an alert there but then realised that wasn't reasonable and that we were failing noisily there where we couldn't recover
markmandel
approved these changes
Feb 23, 2021
markmandel
added
area/operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.